Improved logging performance.

This commit is contained in:
didfet
2015-04-09 17:47:51 +02:00
parent d6a03cc2fe
commit a9de6757f1

View File

@@ -100,7 +100,9 @@ public class LumberjackClient implements ProtocolAdapter {
output.writeByte(FRAME_WINDOW_SIZE); output.writeByte(FRAME_WINDOW_SIZE);
output.writeInt(size); output.writeInt(size);
output.flush(); output.flush();
logger.debug("Sending window size frame : " + size + " frames"); if(logger.isDebugEnabled()) {
logger.debug("Sending window size frame : " + size + " frames");
}
return 6; return 6;
} }
@@ -143,7 +145,9 @@ public class LumberjackClient implements ProtocolAdapter {
uncompressedOutput.close(); uncompressedOutput.close();
Deflater compressor = new Deflater(); Deflater compressor = new Deflater();
byte[] uncompressedData = uncompressedBytes.toByteArray(); byte[] uncompressedData = uncompressedBytes.toByteArray();
logger.debug("Deflating data : " + uncompressedData.length + " bytes"); if(logger.isDebugEnabled()) {
logger.debug("Deflating data : " + uncompressedData.length + " bytes");
}
if(logger.isTraceEnabled()) { if(logger.isTraceEnabled()) {
HexDump.dump(uncompressedData, 0, System.out, 0); HexDump.dump(uncompressedData, 0, System.out, 0);
} }
@@ -158,7 +162,9 @@ public class LumberjackClient implements ProtocolAdapter {
} }
compressedBytes.close(); compressedBytes.close();
byte[] compressedData = compressedBytes.toByteArray(); byte[] compressedData = compressedBytes.toByteArray();
logger.debug("Deflated data : " + compressor.getTotalOut() + " bytes"); if(logger.isDebugEnabled()) {
logger.debug("Deflated data : " + compressor.getTotalOut() + " bytes");
}
if(logger.isTraceEnabled()) { if(logger.isTraceEnabled()) {
HexDump.dump(compressedData, 0, System.out, 0); HexDump.dump(compressedData, 0, System.out, 0);
} }
@@ -167,7 +173,9 @@ public class LumberjackClient implements ProtocolAdapter {
output.write(compressedData); output.write(compressedData);
output.flush(); output.flush();
logger.debug("Sending compressed frame : " + keyValuesList.size() + " frames"); if(logger.isDebugEnabled()) {
logger.debug("Sending compressed frame : " + keyValuesList.size() + " frames");
}
return 6 + compressor.getTotalOut(); return 6 + compressor.getTotalOut();
} }
@@ -181,7 +189,9 @@ public class LumberjackClient implements ProtocolAdapter {
throw new ProtocolException("Frame type should be Ack, received " + frameType); throw new ProtocolException("Frame type should be Ack, received " + frameType);
} }
int sequenceNumber = input.readInt(); int sequenceNumber = input.readInt();
logger.debug("Received ack sequence : " + sequenceNumber); if(logger.isDebugEnabled()) {
logger.debug("Received ack sequence : " + sequenceNumber);
}
return sequenceNumber; return sequenceNumber;
} }
@@ -189,7 +199,9 @@ public class LumberjackClient implements ProtocolAdapter {
try { try {
int beginSequence = sequence; int beginSequence = sequence;
int numberOfEvents = eventList.size(); int numberOfEvents = eventList.size();
logger.info("Sending " + numberOfEvents + " events"); if(logger.isInfoEnabled()) {
logger.info("Sending " + numberOfEvents + " events");
}
sendWindowSizeFrame(numberOfEvents); sendWindowSizeFrame(numberOfEvents);
List<Map<String,byte[]>> keyValuesList = new ArrayList<Map<String,byte[]>>(numberOfEvents); List<Map<String,byte[]>> keyValuesList = new ArrayList<Map<String,byte[]>>(numberOfEvents);
for(Event event : eventList) { for(Event event : eventList) {
@@ -219,5 +231,5 @@ public class LumberjackClient implements ProtocolAdapter {
public int getPort() { public int getPort() {
return port; return port;
} }
} }