Code cleanup

This commit is contained in:
9and3r
2014-08-04 11:33:40 +02:00
parent efd5201b65
commit cd8d9d1c17
10 changed files with 101 additions and 100 deletions

View File

@@ -1,5 +1,5 @@
import random
import logging
import random
logger = logging.getLogger(__name__)
@@ -24,7 +24,8 @@ class DynamicBackground():
# Returns an array with 3 integers in range of 0-255
# The sum of the three integers will be lower than 255*2 (510) to avoid very bright colors
# The sum of the three integers will be lower than 255*2
# (510) to avoid very bright colors
# White text should be seen ok with this background color

View File

@@ -15,8 +15,8 @@ class LibraryScreen():
self.base_size = base_size
self.manager = manager
self.list_view = ListView((0, self.base_size), (
self.size[0], self.size[1] - 2 * self.base_size),
self.base_size, manager.fonts['base'])
self.size[0], self.size[1] - 2 * self.base_size),
self.base_size, manager.fonts['base'])
self.directory_list = []
self.current_directory = None
self.library = None
@@ -63,7 +63,7 @@ class LibraryScreen():
self.go_up_directory()
else:
if self.library[
clicked - 1].type == mopidy.models.Ref.TRACK:
clicked - 1].type == mopidy.models.Ref.TRACK:
self.play_uri(self.library[clicked - 1].uri, True)
else:
self.go_inside_directory(

View File

@@ -1,5 +1,6 @@
import logging
from .screen_objects import ScrollBar, ScreenObjectsManager, TouchAndTextItem
from .touch_manager import TouchManager
from .screen_objects import *
logger = logging.getLogger(__name__)
@@ -58,7 +59,8 @@ class ListView():
self.screen_objects.render(surface)
def touch_event(self, touch_event):
if touch_event.type == TouchManager.click or touch_event.type == TouchManager.long_click:
if touch_event.type == TouchManager.click \
or touch_event.type == TouchManager.long_click:
objects = self.screen_objects.get_touch_objects_in_pos(
touch_event.current_pos)
if objects is not None:
@@ -76,9 +78,9 @@ class ListView():
elif touch_event.direction == TouchManager.down:
self.move_to(1)
#Scroll to direction
#direction == 1 will scroll down
#direction == -1 will scroll up
# Scroll to direction
# direction == 1 will scroll down
# direction == -1 will scroll up
def move_to(self, direction):
if self.scrollbar:
if direction == 1:
@@ -97,7 +99,7 @@ class ListView():
self.current_item)
self.set_selected(self.selected)
#Set selected items
# Set selected items
def set_selected(self, selected):
for number in self.selected:
try:
@@ -111,4 +113,4 @@ class ListView():
True)
except KeyError:
pass
self.selected = selected
self.selected = selected

View File

@@ -5,9 +5,10 @@ from threading import Thread
import urllib
import urllib2
import json
import pygame
import logging
from .touch_manager import TouchManager
from .screen_objects import *
from .screen_objects import ScreenObjectsManager, Progressbar, TouchAndTextItem, TextItem
logger = logging.getLogger(__name__)
@@ -35,14 +36,14 @@ class MainScreen():
if self.track is not None:
if self.image is not None:
screen.blit(self.image, (
self.base_size / 2, self.base_size + self.base_size / 2))
self.base_size / 2, self.base_size + self.base_size / 2))
self.touch_text_manager.get_touch_object("time_progress").set_value(
self.core.playback.time_position.get() / 1000)
self.touch_text_manager.get_touch_object("time_progress").set_text(
time.strftime('%M:%S', time.gmtime(
self.core.playback.time_position.get() / 1000)) + "/" + time.strftime(
'%M:%S', time.gmtime(
self.track.length / 1000)))
self.core.playback.time_position.get() / 1000)) + "/" +
time.strftime('%M:%S', time.gmtime(
self.track.length / 1000)))
self.touch_text_manager.render(screen)
return screen
@@ -136,12 +137,15 @@ class MainScreen():
safe_album = urllib.quote_plus(
MainScreen.get_track_album_name(self.track))
url = "http://ws.audioscrobbler.com/2.0/?"
params = "method=album.getinfo&api_key=59a04c6a73fb99d6e8996e01db306829&artist=" + safe_artist + "&album=" + safe_album + "&format=json"
params = "method=album.getinfo&" + \
"api_key=59a04c6a73fb99d6e8996e01db306829&artist=" \
+ safe_artist + "&album=" + safe_album + "&format=json"
response = urllib2.urlopen(url + params)
data = json.load(response)
image = data['album']['image'][-1]['#text']
urllib.urlretrieve(image,
self.get_cover_folder() + self.get_image_file_name())
self.get_cover_folder() +
self.get_image_file_name())
self.load_image()
except:
self.download_image(artist_index + 1)
@@ -244,4 +248,3 @@ class MainScreen():
return track.album.name
else:
return "Unknow Album"

View File

@@ -3,7 +3,7 @@ import socket
import mopidy
from .screen_objects import *
from .screen_objects import ScreenObjectsManager, TouchAndTextItem
class MenuScreen():
@@ -46,16 +46,10 @@ class MenuScreen():
(0, self.base_size * 4), None)
self.screen_objects.set_touch_object("ip", button)
#self.list_view = ListView((0,self.base_size),(self.size[0],self.size[1]-2*self.base_size), self.base_size, manager.fonts)
#self.list_view.set_list(["Exit mopidy", "Shutdown", "Restart"])
def update(self, screen):
self.screen_objects.render(screen)
# self.list_view.render(screen)
def touch_event(self, touch_event):
# clicked = self.list_view.touch_event(touch_event)
clicked = self.screen_objects.get_touch_objects_in_pos(
touch_event.current_pos)
for key in clicked:

View File

@@ -7,8 +7,8 @@ class PlaylistScreen():
self.base_size = base_size
self.manager = manager
self.list_view = ListView((0, self.base_size), (
self.size[0], self.size[1] - 2 * self.base_size),
self.base_size, manager.fonts['base'])
self.size[0], self.size[1] - 2 * self.base_size),
self.base_size, manager.fonts['base'])
self.playlists_strings = []
self.playlists = []
self.playlists_loaded()

View File

@@ -1,11 +1,12 @@
import traceback
import logging
import mopidy
from pkg_resources import Requirement, resource_filename
import pygame
import mopidy.core
from .main_screen import MainScreen
from .touch_manager import TouchManager
from .screen_objects import *
from .screen_objects import ScreenObjectsManager, TouchAndTextItem, Progressbar
from .tracklist import Tracklist
from .playlist_screen import PlaylistScreen
from .dynamic_background import DynamicBackground
@@ -109,13 +110,12 @@ class ScreenManager():
self.screen_objects_manager.set_touch_object("menu_3", button)
x = button.get_right_pos()
#Menu button
# Menu button
button = TouchAndTextItem(self.fonts['icon'], u" \ue60a",
(x, self.base_size * 7), None)
self.screen_objects_manager.set_touch_object("menu_4", button)
x = button.get_right_pos()
#Down bar
# Down bar
self.down_bar = pygame.Surface(
(self.size[0], self.size[1] - self.base_size * 7), pygame.SRCALPHA)
self.down_bar.fill((0, 0, 0, 128))
@@ -153,19 +153,19 @@ class ScreenManager():
if objects is not None:
for key in objects:
if key == "volume":
value = self.screen_objects_manager.get_touch_object(
key).get_pos_value(
touch_event.current_pos)
manager = self.screen_objects_manager
volume = manager.get_touch_object(key)
pos = touch_event.current_pos
value = volume.get_pos_value(pos)
self.backend.tell(
{'action': 'volume', 'value': value})
self.volume_changed(value)
elif key == "pause_play":
if self.core.playback.state.get() == mopidy.core.PlaybackState.PLAYING:
if self.core.playback.state.get() == \
mopidy.core.PlaybackState.PLAYING:
self.core.playback.pause()
logger.error("pausatzen")
else:
self.core.playback.play()
logger.error("erreproduzitzen")
elif key == "mute":
mute = not self.core.playback.mute.get()
self.core.playback.set_mute(mute)
@@ -198,7 +198,6 @@ class ScreenManager():
self.screen_objects_manager.get_touch_object("mute").set_text(
u"\ue621", False)
else:
logger.error("sartu naiz")
self.screen_objects_manager.get_touch_object("mute").set_text(
u"\ue622", False)
self.screen_objects_manager.get_touch_object("volume").set_value(volume)

View File

@@ -1,6 +1,6 @@
import pygame
import logging
import math
import pygame
logger = logging.getLogger(__name__)
@@ -70,7 +70,8 @@ class TextItem(BaseItem):
self.box = self.font.render(text, True, self.color)
if size is not None:
if size[1] == -1:
BaseItem.__init__(self, pos, (size[0], self.font.size(text)[1]))
height = self.font.size(text)[1]
BaseItem.__init__(self, pos, (size[0], height))
else:
BaseItem.__init__(self, pos, size)
else:
@@ -180,8 +181,8 @@ class Progressbar(TouchObject):
self.text.set_text(str(self.value), True)
else:
self.text = TextItem(font, text, pos, None)
self.text.pos = (self.pos[0] + self.size[0] / 2 - self.text.size[0] / 2,
self.text.pos[1])
self.text.pos = (self.pos[0] + self.size[0] / 2 - self.text.size[0] /
2, self.text.pos[1])
def update(self):
pass
@@ -243,4 +244,4 @@ class ScrollBar(TouchObject):
def set_item(self, current_item):
self.current_item = current_item
self.bar_pos = float(self.current_item) / float(self.max) * float(
self.size[1])
self.size[1])